[auth] IDP access tokens over hail-minted tokens #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-goldstein
force-pushed
the
hailctl-oauth
branch
from
820ad9c
to
a83ba77
Compare
daniel-goldstein
force-pushed
the
hailctl-oauth
branch
from
322eec1
to
a00dbec
Compare
daniel-goldstein
force-pushed
the
hailctl-oauth
branch
from
a00dbec
to
313c4b4
Compare
danking
previously requested changes
Jul 12, 2023
There was a problem hiding this comment.
This is a really great RFC. I'm really glad we're doing these now. I like that you have encoded all this knowledge about authentication, OAuth2, and how Hail is using it into this document. This is a great resource.
I think we should write another one about how we plan to move secrets through the system (aka the metadata server impersonation scheme for Google and whatever we plan to do in Azure).
|
@danking Ready for another look |
|
Sorry I know I'm delinquent. My top priority tomorrow is this. |
danking
reviewed
Aug 2, 2023
rfc/0001-oauth-access-tokens.rst
Outdated
|
|
||
| Unfortunately Google and Azure have slightly different approaches to this interaction. | ||
| Both scenarios will involve installing an OAuth2 client credential on the user's machine | ||
| to be used by the Hail python library, and they will involve similar changes to the ``auth`` |
There was a problem hiding this comment.
capitalize Python throughout unless referring to the binary.
danking
approved these changes
Aug 2, 2023
danking
pushed a commit
to hail-is/hail
that referenced
this pull request
Sep 5, 2023
…13131) Deprecate hail-minted API keys in favor of using access tokens from the identity providers already associated with user identities. For more context and a high-level overview of the implementation, see [this RFC](hail-is/hail-rfcs#2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.